thermal: add hysteresis support and adjust PoE HAT trip points #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: Ram Chandrasekar <[email protected]> Step wise governor increases the mitigation level when the temperature goes above a threshold and will decrease the mitigation when the temperature falls below the threshold. If it were a case, where the temperature hovers around a threshold, the mitigation will be applied and removed at every iteration. This reaction to the temperature is inefficient for performance. The use of hysteresis temperature could avoid this ping-pong of mitigation by relaxing the mitigation to happen only when the temperature goes below this lower hysteresis value. Signed-off-by: Ram Chandrasekar <[email protected]> Signed-off-by: Lina Iyer <[email protected]>
…re after dropping below it Signed-off-by: Serge Schneider <[email protected]>
Signed-off-by: Serge Schneider <[email protected]>
XECDesign
force-pushed
the
poe-hat
branch
3 times, most recently
from
e26d1ea to
6592291
Compare
|
For the curious, this overlay is adding its parameters to the base DTB; without this trick, they would go out of scope when the overlay for a stacked HAT is loaded, meaning they could never be used. |
|
The README entry now requires |
Signed-off-by: Serge Schneider <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends See: raspberrypi/linux#2717 kernel: thermal: add hysteresis support and adjust PoE HAT trip points See: raspberrypi/linux#2700 kernel: Add composite RPi driver for pcm512x DAC HAT cards See: raspberrypi/linux#2702 firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header See: raspberrypi/userland#345 firmware: Add IL HVS component firmware: mmal: Acquire zero copy buffers on being passed to the VPU firmware: video_render: Use per pixel alpha on RGBA and BGRA firmware: video_render: Add support for alpha options (MIX and PREMULT)
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends See: raspberrypi/linux#2717 kernel: thermal: add hysteresis support and adjust PoE HAT trip points See: raspberrypi/linux#2700 kernel: Add composite RPi driver for pcm512x DAC HAT cards See: raspberrypi/linux#2702 firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header See: raspberrypi/userland#345 firmware: Add IL HVS component firmware: mmal: Acquire zero copy buffers on being passed to the VPU firmware: video_render: Use per pixel alpha on RGBA and BGRA firmware: video_render: Add support for alpha options (MIX and PREMULT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the step_wise thermal scaling governor ping pongs around the trip point and ignores the hysteresis value.
This PR steals step_wise hysteresis support from https://patchwork.kernel.org/patch/10384571/. This still results in some bounce at the hysteresis temperature if the 'trend' is rising, which is addressed by the second commit.
In the PoE HAT overlay, a cooling level has been removed and hysteresis values were increased to 5C.