Add composite RPi driver for pcm512x DAC HAT cards #2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prefer not to be merged as I’d like to ensure anything I change for IQaudIO doesn’t effect others and vice versa. Such a change doesn’t feel right.
Gordon
…Sent from my iPhone
On 5 Oct 2018, at 18:05, timg ***@***.***> wrote:
It might be possible to add other drivers but I started with these smaller drivers first.
Allo Piano DAC
DionAudio Loco V2
Justboom DAC
IQAudioIO DAC
I've tested this with the Justboom DAC so it would be great if anyone could test the other cards.
@HiassofT @iqaudio @allocom
You can view, comment on, or merge this pull request online at:
#2702
Commit Summary
ASoC: RPi composite driver for PCM512x based cards
File Changes
M sound/soc/bcm/Kconfig (10)
M sound/soc/bcm/Makefile (10)
D sound/soc/bcm/allo-piano-dac.c (120)
D sound/soc/bcm/dionaudio_loco-v2.c (115)
D sound/soc/bcm/iqaudio-dac.c (221)
D sound/soc/bcm/justboom-dac.c (145)
A sound/soc/bcm/rpi-pcm512x-soundcard.c (371)
Patch Links:
https://github.com/raspberrypi/linux/pull/2702.patch
https://github.com/raspberrypi/linux/pull/2702.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Don't worry Gordon, I promise we'll help you with that when the day comes. |
|
Well if it’s okay with you Phil, it’s okay with me! :-)
I’m a little swamped at the moment so unable to test. Sorry.
Gordon
… On 5 Oct 2018, at 19:37, Phil Elwell ***@***.***> wrote:
Don't worry Gordon, I promise we'll help you with that when the day comes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@timg236 is one of us, and he knows what he's doing. |
|
IQaudio DAC worked fine here, code looks good to me as well, thanks a lot! |
|
If you rebase against the latest 4.18 commits I'll merge it. |
timg236
commented
Oct 8, 2018
| static struct snd_rpi_pcm512x_drvdata drvdata_allo_piano_dac = { | ||
| .card_name = "PianoDAC", | ||
| .dai = snd_allo_piano_dac_dai, | ||
| .digital_gain_0db_name_dt = "alloc,24db_digital_gain", |
There was a problem hiding this comment.
typo: "allo" not "alloc"
timg236
force-pushed
the
soc-snd-rpi-pcm512x
branch
from
24dddaa to
ffe4b34
Compare
Create a new composite driver to support PCM512x based Pi-HAT DAC soundcards in order to reduce the maintenance overhead for upstream changes. This replaces the specific drivers for the following cards: * Allo Piano DAC * DionAudio Loco V2 * Justboom DAC * IQAudioIO DAC
timg236
force-pushed
the
soc-snd-rpi-pcm512x
branch
from
ffe4b34 to
7e0fb11
Compare
done |
|
Merged - thanks, everyone. |
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends See: raspberrypi/linux#2717 kernel: thermal: add hysteresis support and adjust PoE HAT trip points See: raspberrypi/linux#2700 kernel: Add composite RPi driver for pcm512x DAC HAT cards See: raspberrypi/linux#2702 firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header See: raspberrypi/userland#345 firmware: Add IL HVS component firmware: mmal: Acquire zero copy buffers on being passed to the VPU firmware: video_render: Use per pixel alpha on RGBA and BGRA firmware: video_render: Add support for alpha options (MIX and PREMULT)
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends See: raspberrypi/linux#2717 kernel: thermal: add hysteresis support and adjust PoE HAT trip points See: raspberrypi/linux#2700 kernel: Add composite RPi driver for pcm512x DAC HAT cards See: raspberrypi/linux#2702 firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header See: raspberrypi/userland#345 firmware: Add IL HVS component firmware: mmal: Acquire zero copy buffers on being passed to the VPU firmware: video_render: Use per pixel alpha on RGBA and BGRA firmware: video_render: Add support for alpha options (MIX and PREMULT)
|
Hi timg236 & pelwell, |
|
Ah, sorry. I'll fix that now |
|
Thanks timg236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be possible to add other drivers but I started with these smaller drivers first.
I've tested this with the Justboom DAC so it would be great if anyone could test the other cards.
@HiassofT @iqaudio @allocom