Colorspace fixes #4643
Merged
Colorspace fixes #4643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The content looks fine, but none of the commit messages contain the name of the driver that they're changing. |
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
Tested on Raspberry Pi running libcamera. Signed-off-by: David Plowman <[email protected]>
… space RAW color spaces are more usually reported as having full range quantization. Tested using libcamera. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
colorspace-fixes
branch
from
3a80dd5 to
705feba
Compare
|
Ah yes indeed, that should be better now! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 25, 2021
kernel: ARM: dts: vc4-kms-v3d: Always disable firmware HDMI See: raspberrypi/linux#4652 kernel: media: bcm2835-codec: Limit video callbacks See: raspberrypi/linux#4646 kernel: staging/bcm2835-camera: Add support for H264_MIN_QP, H264_MAX_QP, MPEG_VIDEO_FORCE_KEY_FRAME See: raspberrypi/linux#4647 kernel: bcm2835-isp: Colorspace fixes See: raspberrypi/linux#4643 kernel: Unicam Media Controller support See: raspberrypi/linux#4641 kernel: config: Enable FSFS_FS_SECURITY See: raspberrypi/linux#4637 kernel: gpio: bcm-virt: Fix the get() method See: raspberrypi/linux#4638 firmware: userland: Reduce debug_sym error messages See: https://forums.raspberrypi.com/viewtopic.php?f=98&t=322238 firmware: arm_dt: Increase maximum line length to 98 See: raspberrypi/linux#4638
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 25, 2021
kernel: ARM: dts: vc4-kms-v3d: Always disable firmware HDMI See: raspberrypi/linux#4652 kernel: media: bcm2835-codec: Limit video callbacks See: raspberrypi/linux#4646 kernel: staging/bcm2835-camera: Add support for H264_MIN_QP, H264_MAX_QP, MPEG_VIDEO_FORCE_KEY_FRAME See: raspberrypi/linux#4647 kernel: bcm2835-isp: Colorspace fixes See: raspberrypi/linux#4643 kernel: Unicam Media Controller support See: raspberrypi/linux#4641 kernel: config: Enable FSFS_FS_SECURITY See: raspberrypi/linux#4637 kernel: gpio: bcm-virt: Fix the get() method See: raspberrypi/linux#4638 firmware: userland: Reduce debug_sym error messages See: https://forums.raspberrypi.com/viewtopic.php?f=98&t=322238 firmware: arm_dt: Increase maximum line length to 98 See: raspberrypi/linux#4638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@6by9 @naushir
This is a set of small changes to fix colour space issues noticed during libcamera development. Most of them involve sensors that were incorrectly reporting sRGB rather than RAW colour spaces. Additionally I've also made our ISP advertise that it wants full, rather than limited, range RAW input.
Nothing was actually failing before, it was a case of the debug warnings showing that colour spaces were wrong, even though they were being over-written later. I've worked through each of the affected camera modules double-checking that the changes don't break anything!