drivers: bcm2835_unicam: Disable trigger mode operation #4834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@6by9, this does seem to be a valid fix for the pink frames (fingers crossed)! |
|
Only question is do we disable this selectively based on a dt config? Ideally I would hope we can disable this globally. |
pelwell
reviewed
Jan 18, 2022
| @@ -983,11 +983,6 @@ static irqreturn_t unicam_isr(int irq, void *dev) | |||
| } | |||
| } | |||
|
|
|||
| if (reg_read(unicam, UNICAM_ICTL) & UNICAM_FCM) { | |||
| /* Switch out of trigger mode if selected */ | |||
| reg_write_field(unicam, UNICAM_ICTL, 1, UNICAM_TFC); | |||
There was a problem hiding this comment.
To someone who knows nothing about the subject matter, the 1 here is unexpected.
There was a problem hiding this comment.
That's hitting the trigger bit in the ICTL register. It's using UNICAM_TFC as the bitmask.
|
I see little reason not to disable it globally. Typo in commit message "firmeare", but otherwise I'm happy. Possibly worth pinging Laurent et al about this patch as they are upstreaming Unicam. |
On a Pi3 B/B+ platform the imx219 sensor frequently generates a single corrupt frame when the sensor first starts. This can either be a missing line, or invalid samples within the line. This only occurrs using the Unicam kernel driver. Disabling trigger mode elimiates this corruption. Since trigger mode is a legacy feature copied from the firmware driver and not expected to be needed, remove it. Tested on the Raspberry Pi cameras and shows no ill effects. Signed-off-by: Naushir Patuck <[email protected]>
Yes, I will ping Laurent and co. about this commit. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 27, 2022
See: raspberrypi/linux#4845 kernel: drm/vc4_hdmi: Add Broadcast RGB property to allow override of RGB range See: raspberrypi/linux#4850 kernel: Update rpi-display overlay See: raspberrypi/linux#4841 kernel: ARM: dts: BCM2711 AON_INTR2 generates IRQ edges See: raspberrypi/linux#4838 kernel: drivers: bcm2835_unicam: Disable trigger mode operation See: raspberrypi/linux#4834 kernel: random: fix crash on multiple early calls to add_bootloader_randomness See: raspberrypi/linux#4829
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 27, 2022
See: raspberrypi/linux#4845 kernel: drm/vc4_hdmi: Add Broadcast RGB property to allow override of RGB range See: raspberrypi/linux#4850 kernel: Update rpi-display overlay See: raspberrypi/linux#4841 kernel: ARM: dts: BCM2711 AON_INTR2 generates IRQ edges See: raspberrypi/linux#4838 kernel: drivers: bcm2835_unicam: Disable trigger mode operation See: raspberrypi/linux#4834 kernel: random: fix crash on multiple early calls to add_bootloader_randomness See: raspberrypi/linux#4829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a Pi3 B/B+ platform the imx219 sensor frequently generates a single corrupt
frame when the sensor first starts. This can either be a missing line, or
invalid samples within the line. This only occurrs using the Unicam kernel
driver.
Disabling trigger mode elimiates this corruption. Since trigger mode is a
legacy feature copied from the firmeare driver and not expected to be needed,
remove it. Tested on the Raspberry Pi cameras and shows no ill effects.
Signed-off-by: Naushir Patuck [email protected]