ARM: dts: BCM2711 AON_INTR2 generates IRQ edges #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THe AON_INTR2 controller manages the HDMI interrupts, combining them into a single interrupt passed to the GIC. bcm2711.dtsi declares the interrupt as being IRQ_TYPE_LEVEL_HIGH, but it should be IRQ_TYPE_EDGE_RISING. Most of the time the distinction shouldn't matter, but there is a small possibility of losing interrupts unless it is corrected. See: http://lists.infradead.org/pipermail/linux-arm-kernel/2022-January/710292.html Signed-off-by: Phil Elwell <[email protected]>
|
CEC seems fine after this change (as is general hdmi use). |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 27, 2022
See: raspberrypi/linux#4845 kernel: drm/vc4_hdmi: Add Broadcast RGB property to allow override of RGB range See: raspberrypi/linux#4850 kernel: Update rpi-display overlay See: raspberrypi/linux#4841 kernel: ARM: dts: BCM2711 AON_INTR2 generates IRQ edges See: raspberrypi/linux#4838 kernel: drivers: bcm2835_unicam: Disable trigger mode operation See: raspberrypi/linux#4834 kernel: random: fix crash on multiple early calls to add_bootloader_randomness See: raspberrypi/linux#4829
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 27, 2022
See: raspberrypi/linux#4845 kernel: drm/vc4_hdmi: Add Broadcast RGB property to allow override of RGB range See: raspberrypi/linux#4850 kernel: Update rpi-display overlay See: raspberrypi/linux#4841 kernel: ARM: dts: BCM2711 AON_INTR2 generates IRQ edges See: raspberrypi/linux#4838 kernel: drivers: bcm2835_unicam: Disable trigger mode operation See: raspberrypi/linux#4834 kernel: random: fix crash on multiple early calls to add_bootloader_randomness See: raspberrypi/linux#4829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THe AON_INTR2 controller manages the HDMI interrupts, combining them
into a single interrupt passed to the GIC. bcm2711.dtsi declares the
interrupt as being IRQ_TYPE_LEVEL_HIGH, but it should be
IRQ_TYPE_EDGE_RISING. Most of the time the distinction shouldn't
matter, but there is a small possibility of losing interrupts unless
it is corrected.
See: http://lists.infradead.org/pipermail/linux-arm-kernel/2022-January/710292.html
Signed-off-by: Phil Elwell [email protected]