overlays: rpi-poe(-plus): Fix parameters #4877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could have been better worded - the overlays were originally applied before config.txt, but that changed with 29479a7. |
popcornmix
force-pushed
the
rpi-5.15.y
branch
from
2a1d12e to
6065260
Compare
|
Does this look OK to you, @6by9? Note that I avoid having to individually dis/enable the rpi-poe-power-supply node by toggling the status of the poe_mfd parent instead. |
pelwell
force-pushed
the
poefix
branch
2 times, most recently
from
ded59fa to
b4b7cf8
Compare
The support of PoE HATs is complicated because there are two methods to control them - via the firmware, and directly over I2C - the choice between the two methods depending on which side "owns" the i2c0 bus. The firmware determines the ownership of i2c0 by analysing the Device Tree after applying any dtoverlays and dtparams. For this reason the PoE HAT overlays have recently been applied by the firmware _after_ config.txt has been processed, but this has prevented any user-supplied threshold settings from being applied - either because the parameters are unknown or because (after an explicit dtoverlay=rpi-poe) the firmware's reload of the overlay has overwritten the user's settings. Solve the problem by restructuring the rpi-poe overlays to support a mode switch _after_ the overlay has been merged, thereby allowing the overlays to be loaded _before_ config.txt is processed. There is a companion firmware patch that changes the point at which the overlays are loaded, and the parameter used to switch modes, but the updated overlays are still compatible with older firmware, albeit without working parameters. See: raspberrypi/firmware#1689 Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support of PoE HATs is complicated because there are two methods to
control them - via the firmware, and directly over I2C - the choice
between the two methods depending on which side "owns" the i2c0 bus.
The firmware determines the ownership of i2c0 by analysing the Device
Tree after applying any dtoverlays and dtparams. For this reason the
PoE HAT overlays have up to now been applied by the firmware after
config.txt has been processed, but this has prevented any user-supplied
threshold settings from being applied - either because the parameters
are unknown or because (after an explicit dtoverlay=rpi-poe) the
firmware's reload of the overlay has overwritten the user's settings.
Solve the problem by restructuring the rpi-poe overlays to support
a mode switch after the overlay has been merged, thereby allowing
the overlays to be loaded before config.txt is processed.
There is a companion firmware patch that changes the point at which
the overlays are loaded, and the parameter used to switch modes, but
the updated overlays are still compatible with older firmware, albeit
without working parameters.
See: raspberrypi/firmware#1689
Signed-off-by: Phil Elwell [email protected]