Skip to content

media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

naushir
Copy link
Contributor

@naushir naushir commented Feb 9, 2022

The 640x480 mode uses a special binning mode for high framerate operation where
the pixel rate is effectively doubled. Account for this when setting up the
pixel clock rate, and applying the vblank and exposure controls.

Signed-off-by: Naushir Patuck [email protected]

The 640x480 mode uses a special binning mode for high framerate operation where
the pixel rate is effectively doubled. Account for this when setting up the
pixel clock rate, and applying the vblank and exposure controls.

Signed-off-by: Naushir Patuck <[email protected]>
@naushir
Copy link
Contributor Author

naushir commented Feb 9, 2022

@6by9

This probably wants to be cherry-picked onto 5.10 as well.

@pelwell
Copy link
Contributor

pelwell commented Feb 9, 2022

This looks uncontroversial. Would you consider it a bug fix, though? 5.10 is effectively in maintenance mode now.

@naushir
Copy link
Contributor Author

naushir commented Feb 9, 2022

I'd class this as a bug fix rather than a new feature, hence fixing up the 5.10 branch. But I have no strong objections if we don't.

@6by9
Copy link
Contributor

6by9 commented Feb 9, 2022

Looks sensible assuming it ends up with the right numbers.
We had seen exposure values varying frame rate if over half the frame time - did that get resolved as it doesn't appear to be in this patch.

@naushir
Copy link
Contributor Author

naushir commented Feb 10, 2022

That should be resolved with this change. I did test with the exposure light box to verify.

@pelwell pelwell merged commit ff6cb02 into raspberrypi:rpi-5.15.y Feb 10, 2022
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters
See: raspberrypi/linux#4877

kernel: i2c: bcm2835: Make clock-stretch timeout configurable
See: raspberrypi/linux#4855

kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic
See: raspberrypi/linux#4882

kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode
See: raspberrypi/linux#4880

kernel: vc4_dpi fixes
See: raspberrypi/linux#4889

kernel: Change vc4 DSI to being a bridge
See: raspberrypi/linux#4878

kernel: sc16is7xx: Fix for incorrect data being transmitted
See: raspberrypi/linux#4885
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters
See: raspberrypi/linux#4877

kernel: i2c: bcm2835: Make clock-stretch timeout configurable
See: raspberrypi/linux#4855

kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic
See: raspberrypi/linux#4882

kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode
See: raspberrypi/linux#4880

kernel: vc4_dpi fixes
See: raspberrypi/linux#4889

kernel: Change vc4 DSI to being a bridge
See: raspberrypi/linux#4878

kernel: sc16is7xx: Fix for incorrect data being transmitted
See: raspberrypi/linux#4885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants