media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode #4880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 640x480 mode uses a special binning mode for high framerate operation where the pixel rate is effectively doubled. Account for this when setting up the pixel clock rate, and applying the vblank and exposure controls. Signed-off-by: Naushir Patuck <[email protected]>
|
This probably wants to be cherry-picked onto 5.10 as well. |
|
This looks uncontroversial. Would you consider it a bug fix, though? 5.10 is effectively in maintenance mode now. |
|
I'd class this as a bug fix rather than a new feature, hence fixing up the 5.10 branch. But I have no strong objections if we don't. |
|
Looks sensible assuming it ends up with the right numbers. |
|
That should be resolved with this change. I did test with the exposure light box to verify. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 640x480 mode uses a special binning mode for high framerate operation where
the pixel rate is effectively doubled. Account for this when setting up the
pixel clock rate, and applying the vblank and exposure controls.
Signed-off-by: Naushir Patuck [email protected]