pps: Compatibility hack should be X86-specific #5478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of [1], using PPS_FETCH on a 64-bit ARM kernel with a 32-bit userland is broken, returning a timeout. This is because the requested 4-byte alignment for struct pps_ktime_compat (illegal on arm64) results in the timeout flags field being uninitialised. Make the hack specific to X86_64 builds with CONFIG_COMPAT defined. [1] commit c2a49fe ("pps: fix padding issue with PPS_FETCH for ioctl_compat") See: raspberrypi#5430 Fixes: c2a49fe ("pps: fix padding issue with PPS_FETCH for ioctl_compat") Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 30, 2023
See: raspberrypi/linux#5482 kernel: Fix I2C issues for DSI touch and V3 camera See: raspberrypi/linux#5479 kernel: pps: Compatibility hack should be X86-specific See: raspberrypi/linux#5478
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 30, 2023
See: raspberrypi/linux#5482 kernel: Fix I2C issues for DSI touch and V3 camera See: raspberrypi/linux#5479 kernel: pps: Compatibility hack should be X86-specific See: raspberrypi/linux#5478
tiagofreire-pt
added a commit
to tiagofreire-pt/rpi_adafruit_stratum1_chrony
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of [1], using PPS_FETCH on a 64-bit ARM kernel with a 32-bit userland is broken, returning a timeout. This is because the requested 4-byte alignment for struct pps_ktime_compat (illegal on arm64) results in the timeout flags field being uninitialised.
Make the hack specific to X86_64 builds with CONFIG_COMPAT defined.
[1] commit c2a49fe ("pps: fix padding issue with PPS_FETCH for
ioctl_compat")
See: #5430
Fixes: c2a49fe ("pps: fix padding issue with PPS_FETCH for ioctl_compat")