Fix I2C issues for DSI touch and V3 camera #5479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6by9
changed the title
|
Convert back to a draft based on discussions for always cleanly flushing FIFOs through the normal code paths, and implementing the I2C_M_IGNORE_NAK flag. |
On error condition, note the error return code, but still handle the FIFOs in the normal way rather than relying on C_CLEAR flushing everything cleanly. Signed-off-by: Dave Stevenson <[email protected]>
6by9
force-pushed
the
rpi-6.1.y-i2c
branch
2 times, most recently
from
29a7588 to
22a46eb
Compare
If a transaction is aborted immediately on ERR being reported, then the bus is not returned to the STOP condition, and devices generally get very upset. Handle the ERR and CLKT conditions only when TA is not set. Signed-off-by: Dave Stevenson <[email protected]>
Now that transfers aren't aborted immediately (and uncleanly) on errors, and the FIFOs are always drained after all transfers, we can implement I2C_M_IGNORE_NAK by ignoring the returned error value. Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 30, 2023
See: raspberrypi/linux#5482 kernel: Fix I2C issues for DSI touch and V3 camera See: raspberrypi/linux#5479 kernel: pps: Compatibility hack should be X86-specific See: raspberrypi/linux#5478
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 30, 2023
See: raspberrypi/linux#5482 kernel: Fix I2C issues for DSI touch and V3 camera See: raspberrypi/linux#5479 kernel: pps: Compatibility hack should be X86-specific See: raspberrypi/linux#5478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.