-
Notifications
You must be signed in to change notification settings - Fork 460
[Android] Add support of self managed call #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add support of self managed call #310
Conversation
Hello, it could be great to have a README fo this new feature for explaining what is it and how to use it. |
👌 Comment is updated above 👆 |
Does this solution handle all app state scenarios? ie when the app is in the background or dead? |
I'm not sure. I think this change is not related to whether app state is background or dead. It just implements https://developer.android.com/reference/android/telecom/Connection#onShowIncomingCallUi(), and expose a callback for RN app. |
It probably does not handle the scenarios you have in mind..
But in order for this to work, you will have to make sure that the activity that you set those flags on will be destroyed and created again when needed. This is the only way that we've been able to have the incoming call screen always display on top of the keyguard. |
We need to make some tests before merge this PR, but if there is not objections, i think we could merge it after the tests. @manuquentin and @danjenkins any objections about this new features? |
@sboily Totally! |
And progress on this? |
How's the tests going? |
Hello, sorry we don't have find time to start the test... We'll do as soon as possible. |
Closing as #395 is created |
The changes in this pull request is to support self managed ConnectionService.
Example app is updated to show how to use it.
selfManaged
ofIOptions
to true.RNCallKeep.addEventListener('showIncomingCall', youMethodToShowIncomingCall)
youMethodToShowIncomingCall