Support self managed capability

[luxiliu]

This is to support self-managed video call based on @danjenkins's changes.

[codetheweb]

I tried this PR but kept getting the below error:

Do I need to change any methods or setup calls from the current version of this package?

RNCallKeep.setup({
      ios: {
        appName: 'Sample App',
      },
      android: {
        alertTitle: 'Permissions required',
        alertDescription: 'Sample App needs to be able to accept incoming calls.',
        cancelButton: 'Cancel',
        okButton: 'ok',
        imageName: 'phone_account_icon',
        selfManaged: true,
      },
    });

[danjenkins]

Can you change the target branch to my one? The branch is totally not ready to merge in yet.... It disbales hold on Android for starters :)

…

On Mon, 6 Jul 2020, 17:08 Max Isom, ***@***.***> wrote: I tried this PR but kept getting the below error: [image: Screen Shot 2020-07-06 at 11 06 19 AM] <https://user-images.githubusercontent.com/7410405/86614508-bc0a6500-bf78-11ea-99bf-513a8523244b.png> Do I need to change any methods or setup calls from the current version of this package? RNCallKeep.setup({ ios: { appName: 'Sample App', }, android: { alertTitle: 'Permissions required', alertDescription: 'Sample App needs to be able to accept incoming calls.', cancelButton: 'Cancel', okButton: 'ok', imageName: 'phone_account_icon', selfManaged: true, }, }); — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB3LLNS6VMEAKQPPUKMRM3R2HZIXANCNFSM4ORF3U3A> .

[luxiliu]

I tried this PR but kept getting the below error:

Do I need to change any methods or setup calls from the current version of this package?

RNCallKeep.setup({
      ios: {
        appName: 'Sample App',
      },
      android: {
        alertTitle: 'Permissions required',
        alertDescription: 'Sample App needs to be able to accept incoming calls.',
        cancelButton: 'Cancel',
        okButton: 'ok',
        imageName: 'phone_account_icon',
        selfManaged: true,
      },
    });

Hi @codetheweb , do you still see this error?

[codetheweb]

Sorry, I forgot to reply.
We're no longer using this package so I can't currently test it.

[meliodev]

Hey @luxiliu ! I have just tried your latest PR, and I've got the same error 'selfManaged' as @codetheweb. Do you have please a fix in mind for this ?

[luxiliu]

Hi @meliodev, sorry, just updated, can you have a try again?

[meliodev]

Hi @luxiliu !
Here is what I did:

1. AndroidManifest.xml

<uses-permission android:name="android.permission.MANAGE_OWN_CALLS"/>
<uses-permission android:name="android.permission.READ_CALL_LOG"/>

    android: {
        . . .
        selfManaged: true,  // <- I added this 
      }

But now nothing happens when I call
RNCallKeep.displayIncomingCall(callUUID, 'X', 'Y', 'number', true);

I don't know if I have to use some other new methods/listeners. Can you please share a snippet so I can test it. Thanks for your support 💯

[luxiliu]

@meliodev , RNCallKeep.displayIncomingCall() is to trigger system native incoming call ui. Here because it's selfManaged, it won't use the native ui. Yes, there's a new callback. I'll post a snippet later

[luxiliu]

@meliodev , I've updated the example, hope it could help you.

[sboily]

Hello @luxiliu, i like your approach to solve this new feature, thank you for this update. What is the next step to merge this PR? Do you think it's correct for resolving the video issue on callkeep with Android? I haven't tested but i read the documentation on the Android SDK and it looks like a good solution. Any objections here about this PR?

[luxiliu]

@sboily , next step is probably to implement VideoProvider, which is to use system managed ui, but that could be in another PR. @danjenkins , do you have any concerns about this PR?

[meliodev]

Hi again @luxiliu after updating the example I have got this error

[luxiliu]

@meliodev are you able to run the example? I feel like it's the problem with your code.

[meliodev]

@luxiliu I just run the example as it is.
So when I pressed on 'Display incoming call now', showIncomingCall event was triggered. But no ringtone and pop up for answer/decline call shows up. Honestly, I don't know exactly the calling flow I have to use. Am I supposed to use another library to show an answer/call notification with ringtone ? Can you please clarify to me how I can proceed. Thank you again for your help.

[luxiliu]

@meliodev , I'm afraid you need to have a look https://developer.android.com/guide/topics/connectivity/telecom/selfManaged

[meliodev]

@luxiliu first thank you for the awesome work you have provided to this library.
Please I just want some directives as I am stuck with this issue since long time :'( . I have checked the link you gave to me but I couldn't achieve positive results. Can you please tell me briefly the next steps I have to do before redirecting the user to my own videoCall UI.
Here is the flow I am expecting and please correct me if I am wrong.

1. The callee receives a firebase cloud notification which triggers a ringing UI (even when the app is killed and phone is locked)
2. The callee accepts or rejects the call.
3. The callee is redirected to the video call UI if he accepts the call.

Now my main question is

• How can I build an incomingCall UI with ringtone. Is there an existing react native library for that ?

[luxiliu]

@meliodev, sorry, I don't know about such libraries. I'm afraid you have to explore it yourself.

[sboily]

Hello, i checked this PR and it add self managed capability to callkeep and not specially concentrated to the video support. I propose to renamed it to reflect this interesting work. If you are interesting about video support on callkeep, i open this PR #251. It add video support on callkeep. So basically it replace the Answer button by the video button etc ... This i not yet finished, but feedback is welcome.

[sboily]

Please note there is also a work from @Telzio guy here about self managed capability : https://github.com/Telzio/react-native-callkeep/tree/feature-android-self-managed

[danjenkins]

@luxiliu Why'd you close this? :)

[meliodev]

Yes I still had hope for somebody to help with that :( I really need that feature. I would love help and contribute but unfortunately I don't have enough knowledge on that.

[luxiliu]

I'll create a new one

[luxiliu]

I was hoping I could polish the code and raise another PR with some video support, but it turned out I couldn't find myself enough time to do the coding, so I think it's better to reopen it. Please provide feedback and re-review it, thanks.

[luxiliu]

A new pull request is raised to just focus self-managed call support, #310