Skip to content

Set the direction to rtl because Arabic is written from right to left. #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

AhmedBaset
Copy link
Collaborator

@AhmedBaset AhmedBaset commented Apr 29, 2023

Fix Right and left directions issues

What does this PR do?

  • Add direction: rtl; to [lang="ar"] selector.
  • Add direction: ltr; to code blocks.
  • Exchange padding-left, padding-right, margin-left, margin-right, and inset-inline-* values if needed.
  • Exchange IconArrow direction.
  • Edit text-left to text-right if needed.

This PR does not translate the content.

edit ml-5 to mr-5 in the sidebarRouteTree.tsx
@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 93.71 KB (🟡 +88 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.01 KB (🟢 -12 B) 169.73 KB
/500 76.01 KB (🟢 -12 B) 169.72 KB
/[[...markdownPath]] 77.43 KB (🟢 -12 B) 171.14 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@AhmedBaset
Copy link
Collaborator Author

AhmedBaset commented May 1, 2023

@3imed-jaberi
Check failing is because of Prettier Formatting.

The yarn ci-check command which runs prettier:diff which refers to yarn nit:source, throw an error saying error Command failed with exit code 1

It needs before to run:

npx prettier --write --list-different .

To format all files. Then, the yarn ci-check won't fail anymore.

@gaearon
Copy link
Member

gaearon commented May 31, 2023

I'd like to propose that, if possible, RTL handling should be sent as a PR to the main react.dev repo. Then make it a setting here: https://github.com/reactjs/react.dev/blob/ad4f5c7c9555f65d6b889e85427ba3fdfa4e7159/src/siteConfig.js#L7

@AhmedBaset
Copy link
Collaborator Author

I'd like to propose that, if possible, RTL handling should be sent as a PR to the main react.dev repo. Then make it a setting here: https://github.com/reactjs/react.dev/blob/ad4f5c7c9555f65d6b889e85427ba3fdfa4e7159/src/siteConfig.js#L7

Ok

@AhmedBaset AhmedBaset added invalid This doesn't seem right and removed in-review labels May 31, 2023
@AhmedBaset AhmedBaset closed this May 31, 2023
@AhmedBaset
Copy link
Collaborator Author

I'd like to propose that, if possible, RTL handling should be sent as a PR to the main react.dev repo. Then make it a setting here: https://github.com/reactjs/react.dev/blob/ad4f5c7c9555f65d6b889e85427ba3fdfa4e7159/src/siteConfig.js#L7

@gaearon
As Arabic users, we face challenges when reading the documentation due to the LTR settings.
So, I have submitted a pull request to the main react.dev branch.
I kindly request you to review the pull request or assign a maintainer to it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants