-
Notifications
You must be signed in to change notification settings - Fork 107
[DONE]: Translation of Installation #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONE]: Translation of Installation #475
Conversation
No. These are buttons embedded by CodeSandbox. Leave them as same. |
Then this page is ready, I don't need to do anything else ? @A7med3bdulBaset |
Just translate the index in the |
Notice You've edited 3 files other than your page. That is not a right approach. |
You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it? @A7med3bdulBaset |
Yes. Make yor PR for translation only so conflicts don't happen. Just translate two files:
There is already PR for rtl here #470 |
Translation only done in this PR. Thanks for helping |
These changes will be in separate pull request.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
The PR has been merged successfully. |
You can see below visual examples

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?