Skip to content

[DONE]: Translation of Installation #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2023

Conversation

AbdulrehmanSuliman
Copy link

You can see below visual examples
image

image

image

image

image

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

@AhmedBaset
Copy link
Collaborator

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

No.

These are buttons embedded by CodeSandbox. Leave them as same.

@AbdulrehmanSuliman
Copy link
Author

AbdulrehmanSuliman commented May 2, 2023

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

No.

These are buttons embedded by CodeSandbox. Leave them as same.

Then this page is ready, I don't need to do anything else ? @A7med3bdulBaset

@AhmedBaset
Copy link
Collaborator

Just translate the index in the SidebarLearn.json that match your page. Then someone from the maintainers will review it

@AhmedBaset
Copy link
Collaborator

Notice You've edited 3 files other than your page. That is not a right approach.
Turn them back and there is a separated PR for handling rtl.

@AbdulrehmanSuliman
Copy link
Author

AbdulrehmanSuliman commented May 2, 2023

Notice You've edited 3 files other than your page. That is not a right approach. Turn them back and there is a separated PR for handling rtl.

You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it? @A7med3bdulBaset

@AbdulrehmanSuliman AbdulrehmanSuliman changed the title [WIP]: Initial translation of Installation [DONE]: Translation of Installation May 2, 2023
@AhmedBaset
Copy link
Collaborator

AhmedBaset commented May 3, 2023

You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it? @A7med3bdulBaset

Yes. Make yor PR for translation only so conflicts don't happen. Just translate two files:

  • installation.md
  • a key in sidebarlearn.json

Take this PR #473 as a guide example

There is already PR for rtl here #470

@AbdulrehmanSuliman
Copy link
Author

You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it? @A7med3bdulBaset

Yes. Make yor PR for translation only so conflicts don't happen. Just translate two files:

  • installation.md
  • a key in sidebarlearn.json

Take this PR #473 as a guide example

There is already PR for rtl here #470

Translation only done in this PR. Thanks for helping

These changes will be in separate pull request.
@github-actions
Copy link

github-actions bot commented May 30, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.09 KB (🟡 +9 B) 169.72 KB
/500 76.09 KB (🟡 +9 B) 169.71 KB
/[[...markdownPath]] 77.51 KB (🟡 +9 B) 171.14 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@AhmedBaset
Copy link
Collaborator

The PR has been merged successfully.
Your translation is great.
Go ahead and take another page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants