Skip to content

Translated Context.md #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 17, 2019
Merged

Translated Context.md #93

merged 21 commits into from
Nov 17, 2019

Conversation

tamarau
Copy link
Contributor

@tamarau tamarau commented Oct 5, 2019

Thanks for reviewing! 🙂

@netlify
Copy link

netlify bot commented Oct 5, 2019 •
edited
Loading

Deploy preview for de-reactjs ready!

Built with commit f88278c

https://deploy-preview-93--de-reactjs.netlify.com

@ph1p
Copy link
Member

ph1p commented Oct 10, 2019

I think we should write "Context" instead of "Kontext", because this is a technical term in React and all methods are named after it. (setContext etc.)

@tamarau
Copy link
Contributor Author

tamarau commented Oct 12, 2019 •
edited
Loading

Hi, yeah I spent quite a bit thinking about whether to use Kontext or Context. Switched it back to Context 👍

ph1p
ph1p requested changes Oct 13, 2019
View reviewed changes
@ph1p
Copy link
Member

ph1p commented Oct 13, 2019

Hello @tamarau . Thank you for your translation (: Could you please read the pages again. Sometimes it sounds like a little bit to "Google-Translatorish" :/

@tesseralis tesseralis mentioned this pull request Oct 25, 2019
Closed
91 tasks
@miku86 miku86 added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Oct 27, 2019
@tamarau
Copy link
Contributor Author

tamarau commented Oct 30, 2019

Hi @ph1p thanks for reviewing and will do! I know, after living in the UK for so long my German can sound a bit too Denglisch sometimes :(

ph1p
ph1p requested changes Nov 7, 2019
View reviewed changes
@ph1p
Copy link
Member

ph1p commented Nov 7, 2019

Thank you! Please check my suggestion and I'll merge it as soon as possible (:

@tamarau
Copy link
Contributor Author

tamarau commented Nov 10, 2019

@ph1p all done! :)

@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Nov 17, 2019
@ph1p ph1p merged commit 6d9bb24 into reactjs:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph1p ph1p ph1p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamarau @ph1p @miku86