Skip to content

hooks effect last minute review #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

escorponox
Copy link
Contributor

Some things I have noticed after reading the Netlify version.

Related to #158

CC: @carburo @alejandronanez @tesseralis

Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@escorponox Awesome review, I like it a lot 🚀 Just 2 things to change to make it a clearer reading and we're good to go 💯

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for es-reactjs ready!

Built with commit daecd15

https://deploy-preview-176--es-reactjs.netlify.com

1 similar comment
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for es-reactjs ready!

Built with commit daecd15

https://deploy-preview-176--es-reactjs.netlify.com

@Darking360 Darking360 merged commit 14e487b into reactjs:master Feb 20, 2019
@escorponox escorponox deleted the hooks-effect-last-minute-review branch February 21, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants