Skip to content

Translate Rendering Elements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

alchristleo
Copy link
Contributor

No description provided.

@alchristleo alchristleo changed the title Add translation for rendering-elements Translation Rendering Elements Feb 14, 2019
@alchristleo alchristleo force-pushed the tr/rendering-elements branch from 3806147 to f6df06e Compare February 17, 2019 14:22
@netlify
Copy link

netlify bot commented Feb 17, 2019

Deploy preview for idreactjs ready!

Built with commit 62e1758

https://deploy-preview-23--idreactjs.netlify.com

@alchristleo
Copy link
Contributor Author

Hi @regalius @arfianadam please kindly review again 😄, and thanks for the earlier review guys 👍

@alchristleo alchristleo force-pushed the tr/rendering-elements branch from f6df06e to e49b83a Compare February 20, 2019 16:27
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for id-reactjs ready!

Built with commit 62e1758

https://deploy-preview-23--id-reactjs.netlify.com

@alchristleo alchristleo force-pushed the tr/rendering-elements branch from e49b83a to b3e6c32 Compare February 21, 2019 09:40
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me Thanks for the contribution mas @alchristleo ! 🎉

Any comments @arfianadam @gedeagas ?

@tesseralis tesseralis requested a review from arfianadam March 28, 2019 03:11
@gedeagas gedeagas removed their request for review April 12, 2019 12:29
@grikomsn grikomsn changed the title Translation Rendering Elements Translate Rendering Elements Jul 7, 2019
@resir014 resir014 merged commit fb98df2 into reactjs:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants