-
Notifications
You must be signed in to change notification settings - Fork 181
Translate codebase-overview #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for ja-reactjs ready! Built with commit 3a18afe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューしました。Crowdin時代から用語の翻訳の仕方が変わったものなどもあり統一のためのサジェストが多く入っています。残りは読みやすくするための提案です。よろしくお願いします。
https://github.com/reactjs/ja.reactjs.org/pull/156/files ←こちらからバッチでコミットできます。
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
f33b5f5
to
39d6dde
Compare
@smikitky 遅くなりましたが、レビューありがとうございました。すべて反映しました。一点問題がありまして、 |
@thayashi ありがとうございます。これは textlint のルールの方が悪いのだと思うのでいずれ修正しますが、ひとまず箇条書きから句点を抜いていただいてよいでしょうか。ちゃんと確認しておらず申し訳ありません。 |
Co-Authored-By: thayashi <[email protected]>
39d6dde
to
aa09754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thayashi レビューして何点かコメントしましたのでご確認お願いします 🙏
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
Co-Authored-By: thayashi <[email protected]>
@koba04 レビューありがとうございました。反映しましたのでご確認ください。 |
@smikitky 句点を除くとエラーになってしまうので「となります**。」句点のみ強調表示の外に置く形にしました。どうでしょうか? |
@thayashi ひとまずこれで大丈夫です。その問題は他でも出ていた気がするので lint のルールをいずれ調整することにしたいと思います。ありがとうございました。 |
@thayashi mergeしました 🚀🚀🚀 対応ありがとうございました! 👏👏👏 |
This PR is part of Issue #4.