Skip to content

Fix Python 3.11 specific RPC issue #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tovrstra
Copy link
Contributor

@tovrstra tovrstra commented Jun 20, 2024

bugfix ...

Summary by Sourcery

This pull request addresses a specific issue with RPC over sockets in Python 3.11 by adding stop events to ensure the server waits for all requests to be handled before closing. The changelog has been updated to reflect this fix, and tests that were previously skipped for Python 3.11 have been re-enabled.

  • Bug Fixes:
    • Implemented a workaround for a Python 3.11 specific issue where the RPC server closes before all requests are handled by adding stop events for each handler.
  • Documentation:
    • Updated the changelog to document the workaround for the Python 3.11 RPC issue.
  • Tests:
    • Removed the skip conditions for tests that were previously skipped for Python 3.11 due to the RPC issue, ensuring they now run and validate the new workaround.

Copy link
Contributor

sourcery-ai bot commented Jun 20, 2024

Reviewer's Guide by Sourcery

This pull request addresses a specific issue with RPC handling in Python 3.11 by introducing a workaround that involves maintaining a list of stop_events to ensure all requests are handled before the server closes. The changes are documented in the changelog, and previously skipped test cases for Python 3.11 have been re-enabled.

File-Level Changes

Files Changes
stepup/core/rpc.py
docs/changelog.md
Implemented a workaround for a Python 3.11 specific issue in RPC handling and documented the change in the changelog.
tests/test_rpc.py Re-enabled previously skipped test cases for Python 3.11 by removing the @pytest.mark.skipif decorator.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 20, 2024

Here's the code health analysis summary for commits ed0e929..8a74d1e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@tovrstra tovrstra merged commit e27443b into reproducible-reporting:main Jun 20, 2024
7 checks passed
@tovrstra tovrstra deleted the fix-py311-rpc-issue branch June 20, 2024 11:05
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant