Skip to content

Cleaner fix for RPC issue #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

tovrstra
Copy link
Contributor

@tovrstra tovrstra commented Jun 22, 2024

Improves fix from PR #13

Summary by Sourcery

This pull request addresses a bug in the RPC handling mechanism that caused lost connection errors in Python 3.11. It simplifies the connection handling by removing the need for a list of stop events and includes a workaround for a server closure issue fixed in Python 3.12.1.

  • Bug Fixes:
    • Resolved an issue where the server context handler exits before all open requests are handled, preventing lost connection errors in Python 3.11.
  • Enhancements:
    • Simplified the RPC handling by removing the need for a list of stop events, streamlining the connection handling process.

Copy link
Contributor

sourcery-ai bot commented Jun 22, 2024

Reviewer's Guide by Sourcery

This pull request refines the previous fix for the RPC issue by removing the stop_events list and simplifying the connection handling logic. Additionally, it introduces a workaround for a known issue with server.wait_closed() in Python versions below 3.12.1.

File-Level Changes

Files Changes
stepup/core/rpc.py Refactored RPC handling to remove unnecessary stop_events list and added a workaround for a known issue in Python versions below 3.12.1.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 22, 2024

Here's the code health analysis summary for commits 2abd30a..618bb2a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython❌ Failure
❗ 2 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@tovrstra tovrstra merged commit 7a45f73 into reproducible-reporting:main Jun 22, 2024
7 of 8 checks passed
@tovrstra tovrstra deleted the fix2-py311-rpc-issue branch June 22, 2024 11:30
@tovrstra
Copy link
Contributor Author

See #14 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant