[do not merge] RFile Prototype #19151
Conversation
Test Results 20 files 20 suites 3d 14h 11m 41s ⏱️ For more details on these failures, see this check. Results for commit d48773a. ♻️ This comment has been updated with latest results. |
|
Just to put this on the table https://its.cern.ch/jira/browse/ROOT-7400 |
|
|
||
| TEST(RFile, WrongExtension) | ||
| { | ||
| FileRaii fileGuard("test_rfile_wrong.xml"); |
There was a problem hiding this comment.
Until now we have not enforced the convention for the extension.
There was a problem hiding this comment.
But if I'm not mistaken TFile will try to open a TXMLFile if it detects this extension (at least with TFile::Open) and I wanted to avoid that
There was a problem hiding this comment.
That is a slightly different interface per say. TFile::Open (as oppose to the TFile constructor) is supposed to find the right plugin and it indeed bases that search on pattern matching (protocol ... filename .extension) but if some code is creating the pluging class directly then there is less checks (in part because they are redundant, in part because new TXMLFile(filename) is an explicit request to open that file as xml)
| } | ||
| } | ||
|
|
||
| TEST(RFile, IterateKeysRecursive) |
There was a problem hiding this comment.
What does 'recursing' over the directories look like for 'complex' operation? For example creating a graph representation of the file's content (text or in TBrowser nodes); Another example could be create Canvas and subCanvas display the histo of each directory (in an organization mimicking the directory organization).
This gets rid of the deprecation warning about operator ""
With this change, querying for object "a/b/c" will only try to fetch object "c" from directory "b" from directory "a", and not any combination thereof (like object "b/c" from directory "a" or object "a/b/c").
This Pull request:
Draft PR for the new RFile prototype, using a non-RDirectory-based approach (an alternative PR using a RDirectory-based approach will follow soon).
Introduces
ROOT::Experimental::RFilewhich presents a new, minimal interface for reading and writing data to a ROOT file.NOTE: the commit history is a bit messy at the moment, but it's not meant to be "review-ready"; it's more to showcase the current progress of the prototype.