-
Notifications
You must be signed in to change notification settings - Fork 400
Add calibration possibility to IMU broadcaster #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
+ Coverage 85.12% 85.25% +0.13%
==========================================
Files 138 140 +2
Lines 13547 13722 +175
Branches 1188 1191 +3
==========================================
+ Hits 11532 11699 +167
- Misses 1620 1626 +6
- Partials 395 397 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks great
Amazing job as always @christophfroehlich
imu_sensor_broadcaster/include/imu_sensor_broadcaster/imu_sensor_broadcaster.hpp
Outdated
Show resolved
Hide resolved
imu_sensor_broadcaster/include/imu_sensor_broadcaster/imu_transform.hpp
Outdated
Show resolved
Hide resolved
imu_sensor_broadcaster/include/imu_sensor_broadcaster/imu_transform.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Similar to multiplier+offset of the FTS broadcaster, I changed the IMU broadcaster to
I used the method from imu_pipeline, but copied it over to avoid pulling in another dependency. If you prefer, I could do and use a tf2 transform instead of Eigen quaternion to save the calibrated orientation.