Skip to content

Update odometry implementation in diff_drive #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Amronos
Copy link
Contributor

@Amronos Amronos commented Aug 6, 2025

Fixes #271.
Fixes #357.

I have updated the odometry implementation of the diff_drive_controller to fix the above two issues alongside improving the code's readability. This implementation is similar to that of omni_wheel_drive_controller.
I have created some new methods and deprecated the older ones.

Should I also make similar changes to other controllers? If yes, should I do that in a separate PR?

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 79.72973% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.75%. Comparing base (a01fd0b) to head (fe3a568).

Files with missing lines Patch % Lines
diff_drive_controller/src/odometry.cpp 76.31% 8 Missing and 1 partial ⚠️
...iff_drive_controller/src/diff_drive_controller.cpp 83.33% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
- Coverage   85.98%   85.75%   -0.24%     
==========================================
  Files         129      129              
  Lines       13112    13150      +38     
  Branches     1144     1148       +4     
==========================================
+ Hits        11275    11277       +2     
- Misses       1469     1506      +37     
+ Partials      368      367       -1     
Flag Coverage Δ
unittests 85.75% <79.72%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/include/diff_drive_controller/odometry.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 83.22% <83.33%> (+0.64%) ⬆️
diff_drive_controller/src/odometry.cpp 50.87% <76.31%> (-25.44%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant