Skip to content

created.rid: use SOURCE_DATE_EPOCH #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018
Merged

created.rid: use SOURCE_DATE_EPOCH #570

merged 1 commit into from
Jan 5, 2018

Conversation

bmwiedemann
Copy link
Contributor

use SOURCE_DATE_EPOCH instead of current time in created.rid top line
to enable reproducible builds of ruby docs

See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

use SOURCE_DATE_EPOCH instead of current time in created.rid top line
to enable reproducible builds of ruby docs

See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
@aycabta
Copy link
Member

aycabta commented Jan 5, 2018

OK, I understand what you want to do. It's very great for my RDoc development.

@aycabta aycabta merged commit 6f2d59a into ruby:master Jan 5, 2018
@aycabta
Copy link
Member

aycabta commented Jan 5, 2018

I added a test for this at 8194612.

@aycabta
Copy link
Member

aycabta commented Jan 11, 2018

@utkarsh2102
Copy link

Hm, I think this doesn't seem to work.
Reproducibility of ruby-dbus is affected because of rdoc:
ruby-dbus.txt

Any clue what's wrong? :)

@bmwiedemann
Copy link
Contributor Author

@utkarsh2102 Looks like a different issue with mtimes in data.tar.xz - shouldnt those be normalized by dpkg via SOURCE_DATE_EPOCH ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants