created.rid: use SOURCE_DATE_EPOCH #1602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamby
reviewed
May 5, 2017
| @@ -232,6 +232,9 @@ def store= store | |||
|
|
|||
| def update_output_dir(op_dir, time, last = {}) | |||
| return if @options.dry_run or not @options.update_output_dir | |||
| unless ENV['SOURCE_DATE_EPOCH'].nil? | |||
| time = Time.at(ENV['SOURCE_DATE_EPOCH'].to_i).gmtime | |||
There was a problem hiding this comment.
Did you consider setting this at the update_output_dir callsites, rather than overwriting it at the 'last moment'? (Perhap there are multiple ones)
There was a problem hiding this comment.
atm there is mostly the "generate" caller, if we do not count tests, so it could also be done there
use SOURCE_DATE_EPOCH instead of current time in created.rid top line to enable reproducible builds of ruby docs See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
|
@bmwiedemann Can you file this issue to the upstream repository (https://github.com/ruby/rdoc)? Thanks. |
|
filed ruby/rdoc#570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use SOURCE_DATE_EPOCH instead of current time in created.rid top line
to enable reproducible builds of ruby docs
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.