This repository was archived by the owner on Jan 24, 2022. It is now read-only.
error during compilation if two copies of cortex-m-rt are being linked #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linking two copies into the final binary produces a confusing linker error message. This improves the situation by producing an error at compile time. This will have to be backported into the v0.5.x series or you won't get the new error message.
adamgreig
approved these changes
Sep 6, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 6, 2018
106: error during compilation if two copies of cortex-m-rt are being linked r=adamgreig a=japaric linking two copies into the final binary produces a confusing linker error message. This improves the situation by producing an error at compile time. This will have to be backported into the v0.5.x series or you won't get the new error message. r? @rust-embedded/cortex-m (anyone) Co-authored-by: Jorge Aparicio <[email protected]>
therealprof
reviewed
Sep 6, 2018
| @@ -8,7 +8,7 @@ license = "MIT OR Apache-2.0" | |||
| name = "cortex-m-rt" | |||
| readme = "README.md" | |||
| repository = "https://github.com/japaric/cortex-m-rt" | |||
There was a problem hiding this comment.
This should probably be changed to https://github.com/rust-embedded/cortex-m-rt at some point?
|
I've a feeling we're going to bump the version at least one more time today. Maybe be careful with single change version bumps? ;) |
Build succeeded |
|
Thinking more about it: v0.6.x still uses the same symbols and linker sections as v0.5.x so instead of making it an error to use both we could use the semver-trick to make them work together (i.e. having both minor versions in the dependency graph doesn't cause any error). I'll try that and see if it works ... |
|
Published: https://crates.io/crates/cortex-m-rt/0.5.7 which is compatible with v0.6.x |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linking two copies into the final binary produces a confusing linker error
message. This improves the situation by producing an error at compile time.
This will have to be backported into the v0.5.x series or you won't get the new
error message.
r? @rust-embedded/cortex-m (anyone)