Skip to content

docs: update cortex-m-rt version requirement #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: update cortex-m-rt version requirement #234

wants to merge 1 commit into from

Conversation

japaric
Copy link
Member

@japaric japaric commented Sep 6, 2018

generated crates are also compatible with v0.6.x of cortex-m-rt

generated crates are also compatible with v0.6.x of cortex-m-rt
@japaric
Copy link
Member Author

japaric commented Sep 6, 2018

r? @rust-embedded/tools (anyone)
cc @rust-embedded/cortex-m

@japaric
Copy link
Member Author

japaric commented Sep 6, 2018

cc @rust-embedded/cortex-m

to elaborate: there's no need to regenerate the device crate; simply update the version requirement in Cargo.toml.

@japaric
Copy link
Member Author

japaric commented Sep 7, 2018

This turned out to be more complicated than I thought it to be.

It is true that device crates are compatible with both v0.5.x and v0.6.x. However, specifying ">=0.5.0, <0.7.0" as the version requirement of a device crate causes Cargo to compile both a v0.5.x version and a v0.6.x version when using that crate with cortex-m-rt v0.5.x. In other words; Cargo won't try to reduce the number of copies of cortex-m-rt in the dependency graph. Having two copies of cortex-m-rt leads to the compiler error we added in rust-embedded/cortex-m-rt#106 so this version requirement actually causes more problems.

@therealprof
Copy link
Contributor

Yeah, tell me about it... I've invested many hours already updating my few crates for compatibility with the latest cortex-m-rt version.

@japaric
Copy link
Member Author

japaric commented Nov 11, 2018

closing in favor of #235

@japaric japaric closed this Nov 11, 2018
@therealprof therealprof deleted the rt branch July 2, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants