Add support for Access::WriteOnce registers
#264
Conversation
Currently doesn't enforce the write-once nature of the registers, but treats them as write-only.
|
How is this WriteOnce property enforced? |
| } else if fields.iter().all(|f| f.access == Some(Access::WriteOnly)) { | ||
| } else if fields.iter().all(|f| f.access == Some(Access::WriteOnce)) { | ||
| Access::WriteOnce | ||
| } else if fields.iter().all(|f| f.access == Some(Access::WriteOnly) || f.access == Some(Access::WriteOnce)) { |
There was a problem hiding this comment.
I think this second f.access == Some(Access::WriteOnce) comparison is redundant
There was a problem hiding this comment.
This checks that all the fields are either WriteOnly or WriteOnce, instead of only WriteOnly. A register that has both WriteOnly and WriteOnce fields is still WriteOnly and not ReadWrite.
There was a problem hiding this comment.
A register that has both
WriteOnlyandWriteOncefields is stillWriteOnlyand notReadWrite.
Yes, but any register with both WriteOnly and WriteOnce will be processed by first WriteOnce if statement. The next if statement will process just WriteOnly registers. Or not?
Disasm
added
S-waiting-on-review
It isn't, and I couldn't come up with a good way to enforce it on a type level :( |
Maybe |
|
bors try |
tryBuild failed |
322: Once r=therealprof a=burrbull r? @therealprof #264 was taken as base.  Co-authored-by: Hugo van der Wijst <[email protected]> Co-authored-by: Andrey Zgarbul <[email protected]>
Currently doesn't enforce the write-once nature of the registers, but
treats them as write-only.