Skip to content

Once #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2019
Merged

Once #322

merged 3 commits into from
Jul 21, 2019

Conversation

burrbull
Copy link
Member

r? @therealprof

#264 was taken as base.

изображение

Hugo van der Wijst and others added 3 commits December 2, 2018 19:51
Add support for Access::WriteOnce registers
450b410 
Currently doesn't enforce the write-once nature of the registers, but
treats them as write-only.
@burrbull
Merge branch 'write_once' of https://github.com/hugwijst/svd2rust int…
fc33d62 
…o once
@burrbull
ReadWriteOnce + fixes
6afb064
@burrbull burrbull requested a review from a team as a code owner July 20, 2019 08:44
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 20, 2019
therealprof
therealprof approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jul 21, 2019
@bors @burrbull
Merge #322
749c751 
322: Once r=therealprof a=burrbull

r? @therealprof 

#264 was taken as base.

![изображение](https://user-images.githubusercontent.com/3072754/61576487-59a82280-aae3-11e9-9165-aefbf41b2925.png)


Co-authored-by: Hugo van der Wijst <[email protected]>
Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 21, 2019

Build succeeded

@bors bors bot merged commit 6afb064 into rust-embedded:master Jul 21, 2019
@burrbull burrbull deleted the once branch July 21, 2019 13:39
@burrbull burrbull mentioned this pull request Jul 25, 2019
Closed
@adamgreig adamgreig mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @therealprof @rust-highfive