Skip to content

Register derivedFrom and ... (resolve conflicts) #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Register derivedFrom and ... (resolve conflicts) #308

wants to merge 10 commits into from

Conversation

burrbull
Copy link
Member

#256 with conflicts resolved

@burrbull burrbull requested a review from a team as a code owner July 12, 2019 17:16
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 12, 2019
@burrbull
Copy link
Member Author

@therealprof , @Emilgardis let's already solve this issue

@burrbull burrbull mentioned this pull request Jul 13, 2019
Closed
@Emilgardis
Copy link
Member

I'd rather want to use #256 to merge, but I'm not very particular about it.

@burrbull
Copy link
Member Author

You can merge changes to 256 (and I'll close this PR) and then to master, or merge this one.

@burrbull burrbull closed this Jul 15, 2019
@burrbull burrbull mentioned this pull request Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@burrbull @rust-highfive @Emilgardis @ryankurte @nsabovic @wez