Register derived from (resolve) #312
Conversation
svd2rust now uses env_logger instead of printing directly to stderr. env_logger is currently configured to log messages >= info to stderr.
237: Introduce a logging system. r=ryankurte a=achan1989 This pull request makes progress on rust-embedded#183. I've replaced the existing print/eprint calls with the appropriate logging macros, and arbitrarily chose env_logger to handle the logging. This should be functionally identical to the branch point, although the format of the logging output is different -- it's now of the form `<SEVERITY> svd2rust: <message>`. Co-authored-by: achan1989 <[email protected]>
Struct initialisations don't need to repeat field names if they're equal to a local variable. Signed-off-by: Daniel Egger <[email protected]>
302: Remove some noise in the generated code r=Emilgardis a=therealprof Struct initialisations don't need to repeat field names if they're equal to a local variable. Signed-off-by: Daniel Egger <[email protected]> Co-authored-by: Daniel Egger <[email protected]>
|
r? @Emilgardis (rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
S-waiting-on-review
| let mut builder = env_logger::Builder::from_env(env); | ||
| builder.default_format_timestamp(false); | ||
|
|
||
| let log_lvl_from_env = |
There was a problem hiding this comment.
This looks shady. Why store it in a variable and then ignore it?
There was a problem hiding this comment.
I have no idea. All commits except mine are already in master.
This PR is only due to:
#308 (comment)
Would you mind rebasing/squashing this then? |
|
NB: I'm not quite sure how bors handles PRs to non-master branches. |
I don't know how to rebase and not lose authorship. Maybe you can do this? |
|
Or I can reopen #308 . |
|
Hm, okay. On the off-chance messing everything up, I'm going to try something. 😅 |
|
Yay! I just created more conflicts. 💯 |
No description provided.