Skip to content

Generic Writer/Reader #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

burrbull
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 23, 2019
@therealprof
Copy link
Contributor

It works fine and the file size is vastly reduced though the compile time stays almost the same (cargo check on the pac itself). I haven't quite figured out why but the dev binary size is also larger; maybe a missed inline somewhere. But to be honest, I'm no fan of all that macro_rule macros, like not at all.

If we want to go "all macro" I'd crate a procedural macro crate and have either derive or attribute macros for everything; basically just rewrite the SVD file into fully annotated structures and a bit of fairy dust.

@burrbull
Copy link
Member Author

burrbull commented Jul 24, 2019

It works not fine.
I can't to set different offsets for derived fields as they have same type.
Looks like I need const generics to solve the problem.

And you are right, I forgot several inline attributes.

@burrbull
Copy link
Member Author

Close in favour of #331 .

@burrbull burrbull closed this Jul 24, 2019
@burrbull burrbull deleted the generics branch July 26, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants