Generics Part 1 #331
Closed
Generics Part 1 #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
S-waiting-on-review
This was referenced Jul 24, 2019
Closed
therealprof
reviewed
Jul 25, 2019
src/generate/register.rs
Outdated
| }); | ||
| } | ||
|
|
||
| if can_write { | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Uhm, conflict markers?
There was a problem hiding this comment.
Sure, just makes me wonder how you actually tested this... 🤔
There was a problem hiding this comment.
I made merge after PR and tests.
|
Rebased on master. Added This part should not break HALs, but I'm not sure. |
|
Close in favour of #339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @therealprof
I decided to split my changes on 3 steps:
1 - this one adds
RegWrapper for register struct with read, write and other methods (instead of traits we discussed) and replace register'sRandWon generic versions.2 - replace field reader with generic
R3 - replace write proxy with generic
WProxy(require const generics in rust)(see #115 )Example: https://gist.github.com/24a0d1a2e13bb464a7c579a07902a3c6