Skip to content

update svd parser #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2021
Merged

update svd parser #447

merged 3 commits into from
Apr 9, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jun 2, 2020

No description provided.

@burrbull burrbull requested a review from a team as a code owner June 2, 2020 10:07
@rust-highfive
Copy link

r? @adamgreig

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jun 2, 2020
@Emilgardis Emilgardis marked this pull request as draft June 2, 2020 10:35
@Emilgardis
Copy link
Member

Converted to draft

@burrbull

This comment has been minimized.

Sign in to view
@arjanmels
Copy link
Contributor

@burrbull I updated the svd file for Espressif/ESP32, so now should be ok. (I tested it with branch svd_new, but it also passed before the updates, so I might have done something wrong.)

@burrbull
Copy link
Member Author

@burrbull I updated the svd file for Espressif/ESP32, so now should be ok. (I tested it with branch svd_new, but it also passed before the updates, so I might have done something wrong.)

I still see empty <registers /> in the file. Just remove them.

@burrbull burrbull mentioned this pull request Dec 3, 2020
Closed
@burrbull burrbull mentioned this pull request Dec 26, 2020
Merged
@burrbull burrbull force-pushed the svd_new branch 3 times, most recently from a3ebf04 to 2de4eff Compare March 28, 2021 19:42
@burrbull burrbull changed the title [DNM] update_svd_parser update svd parser Apr 8, 2021
@burrbull burrbull marked this pull request as ready for review April 8, 2021 14:35
@burrbull
Copy link
Member Author

burrbull commented Apr 8, 2021

cc @therealprof

@therealprof
Copy link
Contributor

Why are we removing the Spansion tests again?

@burrbull
Copy link
Member Author

burrbull commented Apr 9, 2021

Why are we removing the Spansion tests again?

Spansion SVDs are same as Fujitsu's ones, but more old versions of them with lot of bugs, that are fixed in newer.
So I've left only not doubled files.

therealprof
therealprof approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great then, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 9, 2021

Build succeeded:

@bors bors bot merged commit 5f8c24e into master Apr 9, 2021
@bors bors bot deleted the svd_new branch April 9, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@burrbull @rust-highfive @Emilgardis @arjanmels @therealprof @adamgreig