Skip to content

Le Train Dispatcher #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Le Train Dispatcher #41

merged 6 commits into from
Nov 27, 2019

Conversation

Athorus
Copy link
Contributor

@Athorus Athorus commented Nov 24, 2019

News about a new game : Le Train Dispatcher.

Copy link
Member

@AlexEne AlexEne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, as a general comment, please follow the example from past newsletter entries

@Athorus Athorus closed this Nov 25, 2019
@ozkriff
Copy link
Member

ozkriff commented Nov 25, 2019

Thanks for the PR!

You don't need to close this PR to edit it - just push more commits to your branch: https://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request

@ozkriff ozkriff reopened this Nov 25, 2019
@Athorus
Copy link
Contributor Author

Athorus commented Nov 25, 2019

Thanks for the PR!

You don't need to close this PR to edit it - just push more commits to your branch: https://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request

@Athorus Athorus closed this Nov 25, 2019
@Athorus
Copy link
Contributor Author

Athorus commented Nov 25, 2019

Sorry for closing this PR, I was confused by the interface.

@Athorus Athorus reopened this Nov 25, 2019
@Athorus Athorus requested a review from AlexEne November 25, 2019 18:12
@Athorus
Copy link
Contributor Author

Athorus commented Nov 25, 2019

Here my changes. Sorry about the number of commits.

@17cupsofcoffee
Copy link
Collaborator

@Athorus: Don't worry about it, there's no good way to go back and amend commits through the web interface. They can be squashed down when the change merges 🙂

@Athorus
Copy link
Contributor Author

Athorus commented Nov 26, 2019

Thanks. :) Do i have something else to do ?

@ozkriff ozkriff merged commit d0b8fc2 into rust-gamedev:master Nov 27, 2019
@ozkriff
Copy link
Member

ozkriff commented Nov 27, 2019

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants