Skip to content

FontAwesome missing since mdBook 0.1.7 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
budziq opened this issue May 16, 2018 · 6 comments · Fixed by #425 or #427
Closed

FontAwesome missing since mdBook 0.1.7 #416

budziq opened this issue May 16, 2018 · 6 comments · Fixed by #425 or #427

Comments

@budziq
Copy link
Collaborator

budziq commented May 16, 2018

Since switching to latest mdBook the FontAwesome fonts are missing from the gh-pages
it has been fixed in rust-lang/mdBook#697 but untill it is released to crates.io we need a workaround...
@AndyGauge AndyGauge mentioned this issue May 16, 2018
Closed
budziq added a commit that referenced this issue May 16, 2018
@budziq
Hotfix for missing FontAwesome on mdBook 0.1.7
331171b 
cc #416
@budziq
Copy link
Collaborator Author

budziq commented May 16, 2018

Hotfix was commited in 331171b

I'd preffer to leave this issue open untill new mdBook is relased with propper fix so we remember to cleanup deploy.sh.

AndyGauge pushed a commit to AndyGauge/rust-cookbook that referenced this issue May 26, 2018
@budziq @AndyGauge
Hotfix for missing FontAwesome on mdBook 0.1.7
da3ecce 
cc rust-lang-nursery#416
@AndyGauge
Copy link
Collaborator

0.1.8 released today, this change should be included. I'll test out mdbook 0.1.8 with a PR to remove the hotfix.

@AndyGauge AndyGauge mentioned this issue Jul 9, 2018
Merged
@budziq
Copy link
Collaborator Author

budziq commented Jul 10, 2018

Unfortunately the rust-cookbook published at https://rust-lang-nursery.github.io/rust-cookbook/ started missing the font awesome icons.
font_fail

So I guess that the 0.1.8 does not fix this issue...

@budziq budziq reopened this Jul 10, 2018
@AndyGauge
Copy link
Collaborator

I think the problem is my failure to update the template.

Thanks for catching that, I didn't wait long enough for it to update yesterday.

@AndyGauge AndyGauge mentioned this issue Jul 10, 2018
Merged
@budziq
Copy link
Collaborator Author

budziq commented Jul 10, 2018

Thanks for taking care of this @AndyGauge !

@AndyGauge
Copy link
Collaborator

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@budziq @AndyGauge