Refactor so package publishing only determines git root in one place #9851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Thanks! |
|
📌 Commit a9504cd3681e203aafdae16388689493793cd10d has been approved by |
bors
added
S-waiting-on-bors
|
@bors: r- carrying over #9837 (comment) |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #9865) made this pull request unmergeable. Please resolve the merge conflicts. |
Added unit tests for publishing with - cargo.toml in root + readme in root - cargo.toml in root + readme in subdir - cargo.toml in subdir + readme next to it - cargo.toml in subdir + readme in root (../README) Should fix rust-lang/crates.io#3484 in combination with rust-lang/crates.io#3861
nipunn1313
force-pushed
the
readme_path2
branch
from
a9504cd to
16a84ef
Compare
nipunn1313
changed the title
|
(probably we should prefer something like #9866 to this) |
|
Closing in favor of #9866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor so package publishing only determines git root in one place
Depends on #9837