implemented float mutiplication #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you be sure to try to add some relatively comprehensive tests for this as well (other intrinsics should have a lot of examples) |
|
Sure thing. Will do.
Regsrds.
7 лист. 2017 р. 20:10 "Alex Crichton" <[email protected]> пише:
… Thanks! Can you be sure to try to add some relatively comprehensive tests
for this as well (other intrinsics should have a lot of examples)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADPe53AhLE7mc37nO_5Nr5l87d1QEYkBks5s0J0BgaJpZM4QUuG9>
.
|
|
Ok I'm going to close this in favor of #205 which has some tests as well and I think otherwise may have accidentally duplicated this, but please let me know if something looks off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some code, not tested.