Skip to content

Implement mulsf3 and muldf3 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Implement mulsf3 and muldf3 #205

merged 1 commit into from
Nov 13, 2017

Conversation

aeleos
Copy link
Contributor

@aeleos aeleos commented Nov 8, 2017

It is testing and working with randomly generated unit tests. I had to add a extra generator function to generate larger floats as the previous one only generated extremely small floats that when multiplied together always produced 0.

@alexcrichton
Copy link
Member

Nice! I think that there may be some overlap here with #204 perhaps?

cc @vlad9486

This looks pretty great to me though! I'm curious to hear what @vlad9486 thinks though

@aeleos
Copy link
Contributor Author

aeleos commented Nov 9, 2017

@alexcrichton yea it seems that we ended up working on the same thing at the same time randomly.

@alexcrichton
Copy link
Member

Ok let's merge!

@alexcrichton alexcrichton merged commit bb2c81b into rust-lang:master Nov 13, 2017
@bors bors mentioned this pull request Nov 13, 2017
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
Floating-point environment APIs are private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants