You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe we can change match_version to expose some additional information that makes the next queries easier or, even better, unnecessary?
A simple tweak would be to return the id of the release, making the next query easier.
Change the Exact and Semver variants on MatchVersion to have a (String, id) tuple, not just a String.
Change match_version to query for id as well as version.
Change the usages of match version (linked above) to use that id instead of crates inner join releases ...
jyn514
added
E-easy
Effort: Should be easy to implement and would make a good first PR
mentor
This has instructions for getting started
labels
Jan 23, 2020
If I look at where
match_version
is used, it's always followed by a query on the database fetching therustdoc_status
.- here we fetch
rustdoc_status
: https://github.com/rust-lang/docs.rs/blob/master/src/web/releases.rs#L486- here we fetch
rustdoc_status
andtarget_name
: https://github.com/rust-lang/docs.rs/blob/master/src/web/rustdoc.rs#L160Maybe we can change
match_version
to expose some additional information that makes the next queries easier or, even better, unnecessary?A simple tweak would be to return the id of the release, making the next query easier.
Originally posted by @koenaad in #565 (comment)
The text was updated successfully, but these errors were encountered: