Skip to content

refactor match version #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Conversation

zeegomo
Copy link
Contributor

@zeegomo zeegomo commented Feb 13, 2020

Refactor MatchVersion to contain also the id of the release in order to simplify successive queries.

fix #569

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this :) Just a few nits.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, but otherwise this looks good. Thanks for working on this!

@jyn514 jyn514 merged commit 1175746 into rust-lang:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return crate id from match_version
2 participants