Skip to content

Little Refactors #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 15, 2020
Merged

Little Refactors #683

merged 16 commits into from
Apr 15, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Apr 2, 2020 •
edited
Loading

  • Made code more consistent in formatting
  • More closely held to Rust 2018 idioms
  • Readability improvements

jyn514
jyn514 reviewed Apr 2, 2020
View reviewed changes
@jyn514 jyn514 mentioned this pull request Apr 3, 2020
Merged
@jyn514
Copy link
Member

jyn514 commented Apr 3, 2020

Let's come back to this after the clippy and rustfmt PRs, so I'll be able to see what actually changed instead of looking at formatting.

jyn514
jyn514 reviewed Apr 14, 2020
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Apr 15, 2020

Please update the PR description to reflect what this does, it's changed a lot since you opened it.

jyn514
jyn514 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment.

@jyn514 jyn514 merged commit 8fb139b into rust-lang:master Apr 15, 2020
@Kixiron Kixiron deleted the little-refactors branch April 15, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kixiron @jyn514