Fix clippy warnings and add clippy to CI #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The 'function call' is just an enum variant. - 'wrong self convention', 'cognitive complexity' and 'too many arguments' require too many changes for a clippy PR
pietroalbini
reviewed
Apr 3, 2020
With apologies to @zeegomo for originally requesting the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #683, #684, #685, #686, #687, but only fixes clippy warnings without trying to make any style changes. I plan to make a follow-up PR running
rustfmtshortly.cc @Kixiron
r? @pietroalbini