Skip to content

Refactored web/mod.rs #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2020
Merged

Refactored web/mod.rs #685

merged 11 commits into from
Apr 15, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Apr 2, 2020

  • Removed redundant 'static lifetimes from constants
  • Method chain formatting
  • Transferred from the painful if statement to a wonderful match
  • Overall style and formatting changes

@jyn514
Copy link
Member

jyn514 commented Apr 3, 2020

Can you modify this PR so it doesn't change the formatting? If so I think it would be useful, especially fixing the clippy lints and the match instead of the if/else chains.

@jyn514 jyn514 mentioned this pull request Apr 3, 2020
Merged
jyn514
jyn514 reviewed Apr 14, 2020
View reviewed changes
@jyn514 jyn514 merged commit 589a0b0 into rust-lang:master Apr 15, 2020
@Kixiron Kixiron deleted the freedom-to-the-web branch April 15, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kixiron @jyn514