Skip to content

fix: value of PTHREAD_MUTEX_DEFAULT on illumos #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Berrysoft
Copy link
Contributor

Description

The value on illumos is different to the one on solaris.

Sources

https://github.com/illumos/illumos-gate/blob/master/usr/src/head/pthread.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@pfmooney
Copy link
Contributor

Please see the commentary on this value in #4023.

@Berrysoft
Copy link
Contributor Author

Fair enough:)

@Berrysoft Berrysoft closed this Nov 13, 2024
@Berrysoft Berrysoft deleted the illumos-pthread-mutex-default branch November 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants