Skip to content

cygwin: posix_spawn_file_actions_add[f]chdir[_np] #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Berrysoft
Copy link
Contributor

Description

Rust std needs it for posix_spawn.

Sources

https://github.com/cygwin/cygwin/blob/main/newlib/libc/include/spawn.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Berrysoft
Copy link
Contributor Author

Hope that this PR could catch up the next release:)

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 10, 2025
@tgross35 tgross35 added this pull request to the merge queue Apr 10, 2025
Merged via the queue into rust-lang:main with commit 2c9b059 Apr 10, 2025
46 of 47 checks passed
@Berrysoft Berrysoft deleted the dev/cygwin-posix-spawn-file-actions-addchdir branch April 10, 2025 22:45
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 11, 2025
@tgross35 tgross35 mentioned this pull request Apr 11, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 11, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 15, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 22, 2025
…boet

Use posix_spawn on cygwin

r? `@joboet`

Depends on:
- [x] rust-lang/libc#4387
- [x] rust-lang#140081
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 22, 2025
…boet

Use posix_spawn on cygwin

r? ``@joboet``

Depends on:
- [x] rust-lang/libc#4387
- [x] rust-lang#140081
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2025
Rollup merge of rust-lang#139617 - Berrysoft:cygwin-posix-spawn, r=joboet

Use posix_spawn on cygwin

r? ``@joboet``

Depends on:
- [x] rust-lang/libc#4387
- [x] rust-lang#140081
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 23, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 24, 2025
…boet

Use posix_spawn on cygwin

r? ``@joboet``

Depends on:
- [x] rust-lang/libc#4387
- [x] rust-lang#140081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants