musl: powerpc(64): Decommonize termios definitions #4518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerPC targets use their own, separate definitions of termios that change the order of the c_line and c_cc fields. See: https://git.musl-libc.org/cgit/musl/tree/arch/powerpc/bits/termios.h#n3 https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/termios.h#n3 Signed-off-by: Jens Reidel <[email protected]>
tgross35
approved these changes
Jul 3, 2025
tgross35
added
the
stable-nominated
|
Not sure why the Android CI job got cancelled. Could you please retry it? |
|
Android is just super flaky unfortunately, looks like it made it to the queue now |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
PowerPC targets use their own, separate definitions of termios that change the order of the c_line and c_cc fields. See: https://git.musl-libc.org/cgit/musl/tree/arch/powerpc/bits/termios.h#n3 https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/termios.h#n3 Signed-off-by: Jens Reidel <[email protected]> (backport <rust-lang#4518>) (cherry picked from commit 0dfd754)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
PowerPC targets use their own, separate definitions of termios that change the order of the c_line and c_cc fields. See: https://git.musl-libc.org/cgit/musl/tree/arch/powerpc/bits/termios.h#n3 https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/termios.h#n3 Signed-off-by: Jens Reidel <[email protected]> (backport <#4518>) (cherry picked from commit 0dfd754)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PowerPC targets use their own, separate definitions of termios that change the order of the c_line and c_cc fields.
Sources
https://git.musl-libc.org/cgit/musl/tree/arch/powerpc/bits/termios.h#n3
https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/termios.h#n3
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI