Skip to content

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Aug 1, 2025

Description

This adds NetBSD support for ptsname_r. The function was added in NetBSD 7.

Sources

https://github.com/NetBSD/src/blob/0b011669be2b100a2339b1818db4629981dcdbf0/include/stdlib.h#L326

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
    • haven't done this since I don't know what 'mytarget' is and 'netbsd' didn't work.

I based this on the FreeBSD version, I'm not sure what the sort order in the file is supposed to be though.

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2025

Unknown labels: S-waiting-on-review, O-unix

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2025

Unknown labels: stable-nominated

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Not sure what rustbot is talking about, must be a bug in this deployment

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 1, 2025
@tgross35 tgross35 added this pull request to the merge queue Aug 1, 2025
@tgross35 tgross35 changed the title NetBSD: add ptsname_r support NetBSD: add ptsname_ Aug 1, 2025
@tgross35 tgross35 changed the title NetBSD: add ptsname_ NetBSD: add ptsname_r Aug 1, 2025
Merged via the queue into rust-lang:main with commit e634372 Aug 1, 2025
48 of 52 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
(backport <rust-lang#4608>)
(cherry picked from commit e634372)
@tgross35 tgross35 mentioned this pull request Aug 11, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
(backport <rust-lang#4608>)
(cherry picked from commit e634372)
github-merge-queue bot pushed a commit that referenced this pull request Aug 11, 2025
(backport <#4608>)
(cherry picked from commit e634372)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants