-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Unix: Add sigqueue
#4620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unix: Add sigqueue
#4620
Conversation
c895135
to
50e3c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the PR description with permalinks to the relevant headers.
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, from the PR template:
> * [ ] Relevant tests in `libc-test/semver` have been updated
Looking into this more, I'm not seeing this for OpenBSD or for Android. I don't think it's a safe assumption that this is available on all Unix platforms except Apple and emscripten. So, please add one definition in |
and sigqueue is POSIX.1-2001, not an os-specific extension |
Thanks for the sources. Could you update to exclude OpenBSD and Hurd then? Since there are exclusions, the semver files can't be in unix.txt unfortunately. Instead, it should go in the
At least they seem to have a manpage https://smartos.org/man/3C/sigqueue
I figure you know already but just confirming, we try to match what the platform actually has available since they don't all always have the complete POSIX-defined API. |
Description
Add prototype for
sigqueue
Sources
https://github.com/bminor/glibc/blob/8543577b04ded6d979ffcc5a818930e4d74d0645/include/signal.h#L50-L51
https://github.com/bminor/musl/blob/8fd5d031876345e42ae3d11cc07b962f8625bc3b/include/signal.h#L228
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI