-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add syscall table for x86 and x86_64 #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! Looks like CI may be failing? I don't mind which is added, we can always add both eventually! |
I think we should stick with one set, two sets will unnecessarily enlarge the binary. Let's stick with Well, it didn't like a |
Looks like CI is still failing? |
There were previous definitions of SYS_gettid and SYS_perf_event_open
@bors: r+ |
📌 Commit c0aaf42 has been approved by |
Add syscall table for x86 and x86_64 I'm wondering if we should use `SYS_write` or `__NR_write`. Both are available to C programs.
💔 Test failed - status-travis |
@bors: retry
…On Tue, Jul 18, 2017 at 10:22 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/libc/builds/254884548?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#672 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95ArUWtHRt1fvl7wibsx6Ntawqk6Dks5sPM3TgaJpZM4OZ01p>
.
|
Add syscall table for x86 and x86_64 I'm wondering if we should use `SYS_write` or `__NR_write`. Both are available to C programs.
☀️ Test successful - status-appveyor, status-travis |
@marmistrz @alexcrichton In linux, nix crate cannot be built for these targets anymore |
Oops sorry I missed that breakage! I'll send a PR. |
Restore SYS_* constants to the c_long type cc #672 (comment)
I wasn't fast enough to fix it myself :) |
Thanks for the quick fix ! |
Restore SYS_* constants to the c_long type cc #672 (comment)
I'd rather avoid the duplication, this is discussed in rust-lang#707.
I'd rather avoid the duplication, this is discussed in rust-lang#707.
I'm wondering if we should use
SYS_write
or__NR_write
. Both are available to C programs.