Port #672 and #686 to musl.

[marmistrz]

No description provided.

[alexcrichton]

Looks like CI may be failing?

[marmistrz]

It looks like offending syscalls were added in musl 1.16, you're using 1.15.
http://www.openwall.com/lists/musl/2016/12/25/2
What about updating musl on your side?

[alexcrichton]

Oh certainly! You can update the various scripts in ci/docker for the musl builders

[marmistrz]

It's looks like we've run into #665 on musl too:

bad AF_MAX value at byte 0: rust: 42 (0x2a) != c 43 (0x2b)
bad PF_MAX value at byte 0: rust: 42 (0x2a) != c 43 (0x2b)

[alexcrichton]

Want to update them?

[marmistrz]

It's not so easy. These constants are defined in src/unix/notbsd/linux/mod.rs. This means that updating them will break the glibc CI, since Ubuntu 17.10 still has glibc 2.24. We would need to have glibc 2.25 in our glibc CI.

[alexcrichton]

Oh yeah that's fine, want to duplicate the definition and push them down the module hierarchy?

[marmistrz]

The same will have to be added on x86 and x86_64 for Android.
Maybe we should rethink the whole thing? There'll be three copies of the same syscall table which is Linux-specific.

Maybe it would be better to simply generated them based on the installed libc?

[alexcrichton]

Duplication is fine, we're not going to be generating the libc crate based on what was found at compile time

[marmistrz]

Why not?

[alexcrichton]

Sorry this isn't really quite the PR to debate this on, that question is much broader than just this. If you'd like to land this then the best way will be to duplicate the definitions I believe, otherwise if you'd like to wait and hold off we can continue discussion on perhaps a dedicated issue.

[marmistrz]

So let's land it with duplication for now and discuss it in a separate issue.

[alexcrichton]

@bors: r+

[bors]

📌 Commit 0ef465a has been approved by alexcrichton

[bors]

⌛ Testing commit 0ef465a with merge 5e6853b...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5e6853b to master...